Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

makePublic() doesn't seem to work for packaged methods

Description

A bunch of our MXUnit tests use makePublic() to make package & private methods public. This doesn't seem to work on TestBox. It also doesn't error.

Gliffy Diagrams

Activity

Show:

Luis Majano January 22, 2014 at 1:01 AM

need to fix private issues

Sean Corfield January 21, 2014 at 11:05 PM

FWIW, I deleted line 93 and our tests all pass so that definitely fixes our problem. Not sure if it breaks anything else (but I can't imagine it would).

Sean Corfield January 21, 2014 at 10:27 PM

This mimics how our test code operates (and fails). I was surprised that it killed unqualified calls - I would have expected it to only kill variables.func() calls...

Sean Corfield January 21, 2014 at 10:25 PM

Yup, I just confirmed the exact same thing as Adam. Line 93 in MixerUtil() needs to be removed:

structDelete( variables, arguments.method );

For a repro case, try this:

CallPrivate.cfc

TestMakePublic.cfc

(not actually tested but should be pretty close to what you need to repro)

Luis Majano January 21, 2014 at 10:04 PM

Can I get a quick test case to reproduce please.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Components

Fix versions

Priority

Sentry

Created December 23, 2013 at 9:42 AM
Updated January 22, 2014 at 1:01 AM
Resolved January 22, 2014 at 1:01 AM