We need to review exit codes in Tasks

Description

Exit codes are swallowed up. Ex:

Should the task immediately stop execution when the assertTrue command returns a "failing" exit code of 1? If so, the runCommand method, Command DSL and Task DSL should probably be reworked to actually throw exceptions on a failing status code. That's the only way to have a command automatically fail a task without adding extra plumbing in to capture the exit code and check it every time.

This bring up other questions such as how do we allow someone to PURPOSEFULLY ignore failing command and just keep executing. Try/catch would be one option. Should there be other ways to do it. Look at bash scripts to see how they handle failing commands.

Activity

Show:

Brad Wood September 5, 2018 at 6:21 AM

I think I have this solved, but it needs some testing.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Fix versions

Priority

Sentry

Created August 27, 2018 at 9:27 PM
Updated October 4, 2018 at 5:27 PM
Resolved September 5, 2018 at 6:21 AM