If I want to update a package defined in box.json and just do install --force it will not wipe out the existing folder. This is a major problem if for example the package ships with external jars and updates those. I had the problem with the lucee spreadsheet extension which ships with a lib dir that contains the POI jars. after an update there were 2 sets of POI jars in from different versions. as all those were loaded via javaloader that caused some problems. Only solution is to manually delete the folder before installing the new version.
To reproduce:
1. box install github:cfsimplicity/lucee-spreadsheet#v1.2.0 2. have a look at the lib dir 3. change box.json to use v1.3.0 4. update 5. have a look at the lib dir again (also the javaloader has been removed in 1.3.0 but the folder is still there)
From a slack discussion with brad: Right now CommandBox just dumps the new package over the top of the old one. For most packages, that's find since files are only updated or added. I'm tempted to say the `install` command should always do that, but the `update` command should really probably do an uninstall first.
I would say it should never dump one package on top of the other. either it does nothing because it's already installed, or it does a clean install. i don't think that has something to do with the fact that you use install or update.
Gliffy Diagrams
Activity
Show:
Brad WoodOctober 14, 2017 at 3:01 AM
This is done and seems to work. Any time the install command installs over an existing package either due to the force flag or because the version is newer, the old package will be uninstalled first.
This will mess up anyone who is making changes or storing files runtime inside of their package, but really that was always a bad idea since packages managed by a package manager should be able to disappear at any time.
Brad WoodOctober 14, 2017 at 2:58 AM
also the javaloader has been removed in 1.3.0 but the folder is still there
That statement does not appear to be true. the javaloader folder is still in the Github repo even in the most current version.
Fixed
Pinned fields
Click on the next to a field label to start pinning.
If I want to update a package defined in box.json and just do install --force it will not wipe out the existing folder. This is a major problem if for example the package ships with external jars and updates those. I had the problem with the lucee spreadsheet extension which ships with a lib dir that contains the POI jars. after an update there were 2 sets of POI jars in from different versions. as all those were loaded via javaloader that caused some problems. Only solution is to manually delete the folder before installing the new version.
To reproduce:
1. box install github:cfsimplicity/lucee-spreadsheet#v1.2.0
2. have a look at the lib dir
3. change box.json to use v1.3.0
4. update
5. have a look at the lib dir again (also the javaloader has been removed in 1.3.0 but the folder is still there)
From a slack discussion with brad:
Right now CommandBox just dumps the new package over the top of the old one. For most packages, that's find since files are only updated or added. I'm tempted to say the `install` command should always do that, but the `update` command should really probably do an uninstall first.
I would say it should never dump one package on top of the other. either it does nothing because it's already installed, or it does a clean install. i don't think that has something to do with the fact that you use install or update.