Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

If custom rewrite file is already in correct destination, runwar overwrites it as 0 bytes

Description

See this ticket:

COMMANDBOX-941: urlrewrite.xml has file size of 0 on docker restart but not regular start

Basically if someone provides a custom rewrite file and they've already put it in the correct place in the server home, runwar tries to copy it on stop of itself which wipes it out.

[DEBUG] runwar.server: Copying URL rewrite file /root/serverHome/WEB-INF/urlrewrite.xml to WEB-INF: /root/serverHome/WEB-INF/urlrewrite.xml

Activity

Show:

Miguel MathusAugust 13, 2019 at 5:55 AM

This validation is already done on Runwar,

On class RunwarConfigurer, method configureURLRewrite line 242

basicaly we compare the path before the file is writed

Miguel MathusJuly 30, 2019 at 5:50 AM
Edited

Original Issue runwar #150

Check the source and destination path and skip the copy if the file is already in the correct place. This was on a Docker container.

A RunwarConfigurer class was created, with a configureURLRewrite method that consideres this. this need to be tested

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Fix versions

Priority

Components

Sentry

Created July 24, 2019 at 7:37 PM
Updated September 17, 2019 at 3:47 PM
Resolved August 13, 2019 at 5:56 AM