Modules that include applicationhelpers are incompat with modules.autoReload setting, add recognition

Description

Modules that include applicationhelpers are incompat with modules.autoReload setting.

This is because they do not remove their applicationhelper from the setting array when the module is unloaded. Therefore, if the module is loaded, unloaded, and reloaded, the applicationHelper will be added TWICE to the setting array.

The modules should clean up after themselves in the unload() method.

Another thing to consider would be a check for duplicate items in the array as a fail safe.

Gliffy Diagrams

Activity

Show:

Brad WoodJanuary 28, 2015 at 4:57 AM

Please merge the pull requests

Luis MajanoJanuary 20, 2015 at 10:24 PM

Read it too fast, sure, go for it.

Brad WoodJanuary 20, 2015 at 9:31 PM

I'm not sure what the confusion is, Luis. I spelled out in my last comment what the approach would be. it's just a simple arrayDeleteAt(). Would you like me to just submit a pull request for this? It's like a 5-minute change per module.

Luis MajanoJanuary 20, 2015 at 7:44 PM

This has been always like this and always mentioned in the docs that module auto reload causes issues. With that said, I am not sure what the best approach for resolution is. We can schedule this for the first patch release.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Fix versions

Priority

Sentry

Created January 20, 2015 at 7:18 AM
Updated February 9, 2015 at 7:57 PM
Resolved January 28, 2015 at 4:57 AM