SES is always disabled on RequestContext until RoutingService request capture : SES is the new default for ColdBox Apps

Description

If an attempt to build a link is made any time before the RoutingService fires its requestCapture ( e.g. within the load of a module ), that link is built non-SES, because an explicit override of the default SESEnabled happens in the init of the RequestContext: https://github.com/ColdBox/coldbox-platform/blob/development/system/web/context/RequestContext.cfc#L242

So, for example, if a ContentBox module tries to add an Admin menu link in the `onLoad` event, this link will be non-SES because the routing service has not captured the request.

Suggest removing the explicit override of the Context default so that SES remains enabled by default within the framework lifecycle.

Since we are explicitly setting that value to `true` in the initial requestCapture, I'm not sure it makes sense to even have the override in the RoutingService ( https://github.com/ColdBox/coldbox-platform/blob/development/system/web/services/RoutingService.cfc#L180 ) to flip, if we remove the override in the RequestContext.

Activity

Show:
Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Components

Fix versions

Priority

Sentry

Created February 18, 2022 at 1:30 PM
Updated May 27, 2022 at 2:51 PM
Resolved May 27, 2022 at 2:50 PM