Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Update parser to allow for `@module` notations on imports and `new` operators

Description

Update parser to allow for @module notations on imports and new operators

 

Activity

Show:

Brad Wood October 24, 2024 at 6:04 PM

Ok, thanks for confirming

Luis Majano October 24, 2024 at 3:06 PM


Brad Wood 17 hours ago

Just confirming, what will a star import from a module look like. This?

Yes. This is accounted for already in the ImportDefinition parse

 

Also, should we reject starting imports with an alias? YES. There should never be aliases on star imports. Since it can only alias one class

Luis Majano October 24, 2024 at 7:14 AM

thats the price you pay. Even on ColdBox this happens. Suggestion. Never add @ to class names

Brad Wood October 23, 2024 at 10:16 PM
Edited

What if there is a Box class with an @ in the name like /models/Foo@bar.bx. This would look like a module

And if it’s really in a module, it would be ambiguous

Is that a valid Box Class name? Box classes allow basically any chars allowed by the file system.

Brad Wood October 23, 2024 at 10:13 PM
Edited

Just confirming, what will a star import from a module look like. This?

Also, should we be rejecting start imports with an alias?

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Components

Fix versions

Priority

Sentry

Created October 14, 2024 at 1:15 PM
Updated October 25, 2024 at 1:40 PM
Resolved October 18, 2024 at 2:30 PM