BaseEntity.assignAttribute assumes all non-simple values are structs

Description

We had some code that worked in previous versions of Quick that started failing with this error on line 237 of BaseEntity.cfc:

The attribute in question is a binary field (cf_sql_varbinary). The relevant code is assuming that a non-simple value must be a struct:

I know everybody hates type checking but I put in a workaround that replaces that first line with:

Might be faster or preferable to do isStruct or some other alternative - only had a moment to get into it.

Environment

None

Activity

Show:
Samuel W. Knowlton
December 27, 2019, 1:31 PM

This seems like a pretty small fix - do you want a PR for this, or do you prefer a different solution?

Fixed

Assignee

Eric Peterson

Reporter

Samuel W. Knowlton

Labels

None

Priority

Major