Widget Discovery Mode regression in Theme location change

Description

Looking at the widget discovery more... it looks like you need to state the widget is a theme widget with the `~widgetName` syntax when using the CB.widget() method... otherwise it errors because it doesn't know to look in the theme folder location in the contentbox-custom location.

I guess this wasn't needed before. It knew how to go look for it... before we introduced the new location for Custom Themes.

This is a backwards compat in this case, do we want to lease this as is, or put in some wrapper to catch this scenario?

Widget Lookups

The way to search for widgets are:

1. Theme
2. Custom Widgets
3. Core Widgets

Widget Markup

Activity

Show:
Gavin Pickin
April 13, 2018, 7:28 AM

Why are we using Maps for Core widgets, and custom widgets, but module widgets and theme are not?

Everytime we ask for getWidgets() we are also doing all the file IO again.
Shouldn't this be stored internally... and then just updated if we need to?
Why don't we build a widgetMap and return that?

If we build one or more maps, for each of the types, this wouldn't be too hard to update.
Thoughts on this
Seems like it could use some caching.

Fixed

Assignee

Luis Majano

Reporter

Gavin Pickin

Labels

None

Components

Fix versions

Affects versions

Priority

Major
Configure