Uploaded image for project: 'ContentBox Modular CMS'
  1. CONTENTBOX-768

Admin Layout - loop through jsFullAppendList and cssFullAppendList expects no extension

    Details

    • Type: Improvement
    • Status: Resolved (View workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects versions: 3.0.0
    • Fix versions: 3.1.0
    • Components: Administrator
    • Labels:
      None

      Description

      I believe the code that loops through those elements, for a full url shouldn't add an extension, I think we should expect the full url.

      <cfloop list="#event.getValue( "cssAppendList", "", true )#" index="css">
              <cfset addAsset( "#prc.cbroot#/includes/css/#css#.css" )>
      </cfloop>
      <cfloop list="#event.getValue( "cssFullAppendList", "", true )#" index="css">
              <cfset addAsset( "#css#.css" )>
      </cfloop>
      

      I know since we're looping through a css or js variable, we could assume this, but this creates complications when the url might not need an extension, or have query params, or other non normal path considerations.

      I think we should drop the .css and .js, only for the cssFullAppendList and the jsFullAppendList, not for the normal cssAppendList and jsAppendList.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                Gpickin Gavin Pickin
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: