Core settings shouldn't be deletable, add a boolean distinction on core/custom settings

Description

If you delete some settings the settings view throw errors. So you cannot reupload the old settings.

I think the core settings should be only editable. We could remove the delete button.

Otherwise we should provide a different view for uploading the old settings, probably on the import tools.

Activity

Show:
Luis Majano
February 5, 2016, 3:48 PM

Hmm, good point. HOwever, there is no way right now to know which is a core setting or not unless we add a boolean bit. I am ok with adding one if needed.

Luis Majano
February 5, 2016, 3:48 PM

what do you think?

Gavin Pickin
February 5, 2016, 5:16 PM

I think we should add it.
Since it could BREAK if we do not.
Although we should try default the settings if possible (especially for upgrade paths - its painful if we "miss" something).

Obviously themes, modules etc, should default values that don't exist.

Francesco Pepe
February 6, 2016, 12:35 AM

Add a boolean flag it's the best solution.

Bad solution is to count the core settings and check if it match in range. For example from 1 to 150 are core settings, we shoyld not show delete button and also add a check to remove handler.

Also we could declare setting that match "cb_" prefix are core settings...

Brad Wood
February 6, 2016, 3:11 AM

What about an option to "restore defaults". That may not be viable though if a deleted setting can bring down the entire site though.

Fixed

Assignee

Luis Majano

Reporter

Francesco Pepe

Labels

None

Components

Fix versions

Affects versions

Priority

Major