the git bullet train car disappears while current working directory is not the root project folder

Description

The server version car also disappears, so that would also be another nice to have.

Activity

Show:
Brad Wood
December 22, 2020, 6:17 PM

The logic would need to be changed to climb up the tree until it found a server or a Git repo. Two potential issues with that-- the performance overhead (we’d need to test) and if it would find random servers or Git repos in higher directories that you didn’t want it to find.

Since bullet train is a separate module and not part of the CommandBox core, the logic is here:

https://github.com/commandbox-modules/commandbox-bullet-train/blob/master/inteceptors/Server.cfc#L18

and here:

https://github.com/commandbox-modules/commandbox-bullet-train/blob/master/inteceptors/Git.cfc#L52

Daniel Mejia
December 22, 2020, 6:31 PM

Ok. I’m going to give it a shot. For now, I’m going to directly modify the installed bullet train module in my home commandbox directory. I know I can use “reload” to keep testing my changes.

I guess this issue can be closed here and I’ll submit a pull request on github?

Brad Wood
December 22, 2020, 6:57 PM

Well, this really isn’t the right place for the ticket, but we don’t really have a dedicated issue tracker for the little modules like that.

As far as dev, do this:

  1. uninstall your local bullet train

  2. clone the bullet train repo

  3. run “install” in it

  4. run “link” in it

now, you can develop and use ‘reload’ to test. When you like it, just commit the repo. After you’re done, you can run “unlink” and then reinstall the main package again.

Daniel Mejia
December 22, 2020, 7:18 PM

Thanks Bro. Here is the pull request.

Assignee

Unassigned

Reporter

Daniel Mejia

Labels

Affects versions

None

Fix versions

None

Priority

Minor
Configure