Automated flag negation hint is the same as the hint for the flag itself

Description

Tab completion is incredibly helpful. I think this is an area where it could be slightly improved.

Currently, the hints provided for flag and the flag negation (--no{paramName}) are the same:

I think having the hint for the negation indicate in some way that it is negating the flag, so that the text is different, would be helpful.

I haven't thought about this too deeply - off the top of my head, one approach might be: (Negate --force flag) - because the flag and its hint will already be showing. Just a thought.

Also, more for my own reference, I think these are the lines that deal with this: https://github.com/Ortus-Solutions/commandbox/blob/8d12ac9b13b7ff95af4cd1f7b5bac7a92785ddc6/src/cfml/system/util/jline/CommandCompletor.cfc#L182

Activity

Show:
Brad Wood
May 19, 2020, 10:30 PM

I don’t really care what order it is done so long as we add the change to CommandBox all at the same time.

Matthew Clemente
May 31, 2020, 12:21 AM

Noticed the "fixed in 5.2" for this. I haven't had the chance to roll through the commands making the update yet (though it's been on my to-do this). I was planning on doing it (since I raised the issue). Are you taking care of it, or would you still like me to?

Brad Wood
May 31, 2020, 12:30 AM

Assigning the version number simply means I’m slating it to be done for that release. I wasn’t planning on taking over the ticket or anything, just lining up some things I know I want to get out in 5.2

Matthew Clemente
May 31, 2020, 12:31 AM

Hahaha. Got it. Sounds good. Now I've got a deadline. That always helps.

Matthew Clemente
June 30, 2020, 5:31 PM

Ok, added this: https://github.com/Ortus-Solutions/commandbox/pull/236

A bunch of commands from the export were not built in, but from other packages, like CFConfig/CFMigrations.

I think I got all the built in ones. Take a look and let me know what you think about it.

Assignee

Brad Wood

Reporter

Matthew Clemente

Labels

None

Affects versions

Fix versions

Priority

Major

Components

Configure