Tuckey UrlRewrite DTD version issues

Description

The default urlrewrite.xml file (and I assume others that are derived from it manually by users) uses the urlrewrite DTD in version 3.2, even though the latest version is 4.0.3/4 (not sure what exactly is bundled in runwar).

The problem with the DTD is version 3.2 are the two lines below - they don't validate against 3.2, but only against the 4.0 DTD.

This will most likely not cause an issue with any code, but at least it'll create a confusing impression when one is using an IDE with DTD validation (such as IntelliJ).

Suggested changes:

1. Change DTD in the default rewrite xml file to:

2. Update all samples/documentation accordingly.

Activity

Show:
Brad Wood
March 30, 2020, 6:14 PM

Great ticket , I honestly never even noticed the rewrite files had a DTD. Those two features were “recent” additions to the library. And by recent, I mean years ago, but it’s been a very slow moving library. Can you send a pull to update the default XML rewrite file?

Kai Koenig
March 30, 2020, 8:47 PM

Yup, will do that as an intermediate fix.

Following our discussion in CB Slack and the "discovery" that there's a 5.0.x fork being used in runwar, I'm wondering if there shouldn't be an accordingly maintained DTD for 5.0 hosted on cfmlproject.org. That'd certainly be the ideal solution.

Brad Wood
April 7, 2020, 12:11 AM

So far as I know, our fork of tuckey rewrites hasn’t added anything to the DTD that isn’t in the main project’s 4.0 version.

Kai Koenig
June 28, 2020, 7:25 AM

for the code

Kai Koenig
June 28, 2020, 7:44 AM
Edited

for doc change

Assignee

Brad Wood

Reporter

Kai Koenig

Labels

None

Affects versions

Fix versions

Priority

Major

Components

Configure