Stop expanding /WEB-INF paths in servlet init params

Description

Original runwar issue #143

Servlet init params that start with /WEB-INF are replaced with the full path when loaded, but this causes issues if the web-inf actually points to a folder that doesn't contain "web-inf" in it since the mapped resource manager stops resolving the paths correctly and tries to put them in the web root.
See if we can stop doing this and have Adobe engines still work properly.

The repaces this ticket is referring to also appears to add extra slashes into the paths. For instance:

 

Activity

Show:
Miguel Mathus
July 27, 2020, 4:50 PM

it was Partially fixed,I will resume it

Miguel Mathus
August 4, 2020, 6:36 PM

Hi , In case you are around over the week, I just want to tell you that, for COMMANDBOX-1012, a portion of code was used to get the CanonicalPath() for the web-inf and stored that path into a variable called webinfPath.
Then, when the init params were received, runwar was evaluating, if the parameter had a WEB-INF in it, and then the parameter was ignored, and the value from the variable webinfPath was used.This logic was removed and the parameter remains untouched.

 


I have modified the unit tests,and I got this results

 

I have used the web.xml examples that are within runwar.

Miguel Mathus
August 4, 2020, 6:42 PM

Unit tests changes:

Brad Wood
September 29, 2020, 11:22 PM

is this ticket complete? Can we resolve it?

Miguel Mathus
September 29, 2020, 11:58 PM

yes it is, we review it on a call

Assignee

Miguel Mathus

Reporter

Miguel Mathus

Labels

None

Affects versions

None

Fix versions

Priority

Major

Components

Configure