RendererEncapsulator: use of filter method for rendererVariables is inefficient

Description

Doing some testing using FusionReactor shows that the RendererEncapsulator.cfm has an inefficiency around how it merges the renderVariables struct into the variables scope for the module include.

It currently does:

Whether it is the inline variables.append call, or the `.filter( closure )` call I'm not sure, but simplifying this to the following saved > ~75% of the memory footprint of this logic in Lucee:

Looking at it, I think the exclusion of these variables is not strictly necessary here - but I could be wrong.

Activity

Show:
Luis Majano
December 16, 2020, 5:42 PM

I left comments on the approach and merged maually some of your updates. Please test and let us know if there are other things we can do on this.

Brad Wood
December 7, 2020, 4:31 PM

I left some comments and questions on the pull.

Fixed

Assignee

Luis Majano

Reporter

Dominic Watson

Labels

None

Fix versions

Priority

Major