Whoops should validate a file exists before trying to present it to the code viewer

Description

File or directory [/org/lucee/cfml/HelperBase.cfc] does not exist

https://www.screencast.com/t/zhuC5mMv00F

I get this exception regularly - it's broken in Whoops somewhere so I can't find the location of the bug that caused the original problem.

Activity

Show:
John Wilson
November 30, 2020, 5:56 PM

Gotcha. I wonder if a message to that effect could be included in those blank spaces just so people don’t think it’s broken.

Luis Majano
November 30, 2020, 5:28 PM

Read. I dont think we can do much more than that

Luis Majano
November 30, 2020, 5:27 PM

It’s a compromise since the exception is from core files that can’t be trad

Luis Majano
November 30, 2020, 5:27 PM

That’s tricky because the actual exception is on a non navigable file in the core of the cfml engjne. At least the fix makes sure it doesn’t break but the UI will be empty because that file can be read or be navigated to

John Wilson
November 28, 2020, 6:32 PM

I pasted your fix into my local code as it’s not showing up in the @be version yet. But something isn’t working right still - https://www.screencast.com/t/tMIvkHFaP And Whoops shows blank screens: https://www.screencast.com/t/bmfmww3zEa4

Fixed

Assignee

Luis Majano

Reporter

John Wilson

Labels

None

Fix versions

Priority

Major