bug report view is not thread safe

Description

Bootstrap.cfc's processException() just include inside savecontent but any variables defined in the cfm will pollute Boostrap's variables scope that's not thread-safe.

E.g. /coldbox/system/includes/BugReport.cfm will leak arrayTagContext and i (loop index).

Consider including it by cfmodule so that the view variables will not leak? Or update the doc to require variables to be in local scope (cannot use 'var' keyword, but 'local' seems to work).

Activity

Show:
Luis Majano
July 19, 2016, 5:16 PM

Good observation. I am leaning towards using the `local` scope. Thoughts on this?

Henry Ho
July 19, 2016, 5:42 PM

Sure, please update the doc, and also add an inline comment to the default bugreport.cfm in case they want to make a custom one using that file as a template.

Henry Ho
July 19, 2016, 5:43 PM
Edited

And FYI, the cfmodule & cfinclude are slow with sandbox security on because of the extra permission checking. So please consider using less of them in your frameworks for the best performance under ACF, thanks.

Fixed

Assignee

Luis Majano

Reporter

Henry Ho

Labels

None

Components

Fix versions

Affects versions

Priority

Major
Configure